Fix bug where some directories were skipped #18
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
fredden
force-pushed
the
dir-order-not-guaranteed
branch
from
146369c to
c7782d0
Compare
|
Is this still relevant? |
Yes, I think it is. The bug still exists. However, it's likely that the system on which this runs for production just happens to return the |
| continue; | ||
| } | ||
| if ($f === '.git') { | ||
| if (strpos($f, '.') !== false) { |
There was a problem hiding this comment.
Shouldn't this be simply if ($f[0] === '.'), a . could exist in the reset of the filename.
There was a problem hiding this comment.
We could do this, however a dot is not a valid character in a language code.
|
@fredden ? |
Hi. I'm away from my laptop currently, so I can't easily update the code here. Would you like me to apply the change you suggested? I think the code is fine as-is, but I will make changes as required. |
|
This is a bit of a tangent, but just to throw it out there -- this script should not live in the |
|
@jimwins I am not sure if I agree here, as this is code that runs while doing things with specifically checked out things on the server? |
I hadn't looked at what the script operated on (generated version of the docs), but in general I think this is analogous to the translation status script we moved from web-doc to doc-base. I think that scripts generating information about the documentation should be in doc-base. |
3 participants
I noticed this bug while working on another contribution. After calling
opendir(), the first two results are thrown away. While these are usually.and.., that's not guaranteed. In my case, the language directory in question was one of these first two entries, so no documentation was generated. The first change here is no longer throwing away the first two directory entries. The second change, is to ignore all entries which have a dot in their name. No language codes include a dot. (Some have a dash/hyphen/underscore, but no dots.) This realisation lead to cleaner code and more efficient run as we no longer have to ask the file-system if something is a directory or not as often.